Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger unified build on rc and hotfix-rc branches #5108

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented Dec 4, 2024

🎟️ Tracking

📔 Objective

Trigger self-hosted docker unified build on rc and hotfix-rc branches. We do need to do that to push the beta tag to the internal container registry. Based on that beta tag, the self-hosted docker unified actual release version is released to the docker hub. Lacking the build trigger on rc and hotfix-rc breaks the release strategy for self-hosted docker unified.

After the merge, this needs to be cherry-picked to the current rc branch.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team December 4, 2024 12:20
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.65%. Comparing base (94fdfa4) to head (020a7ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5108   +/-   ##
=======================================
  Coverage   43.65%   43.65%           
=======================================
  Files        1433     1433           
  Lines       66029    66029           
  Branches     5969     5969           
=======================================
  Hits        28827    28827           
  Misses      35958    35958           
  Partials     1244     1244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michalchecinski michalchecinski enabled auto-merge (squash) December 4, 2024 12:53
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Logo
Checkmarx One – Scan Summary & Detailsc02ae8fc-d43f-4c01-9d38-5c19a5faefd1

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build.yml: 581 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 666 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 618 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 547 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@michalchecinski michalchecinski merged commit 470a126 into main Dec 4, 2024
51 of 52 checks passed
@michalchecinski michalchecinski deleted the trigger-unified-on-rc-branches branch December 4, 2024 13:19
michalchecinski added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants