Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOTP Inline Menu feature flag #5112

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

differsthecat
Copy link
Member

🎟️ Tracking


📔 Objective

Add the key for the inline menu totp flag

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@differsthecat differsthecat requested a review from a team December 4, 2024 18:55
Copy link
Contributor

github-actions bot commented Dec 4, 2024

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
Autofill inline-menu TOTP inline-menu-totp

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.14%. Comparing base (74e8693) to head (29e8b6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5112   +/-   ##
=======================================
  Coverage   43.14%   43.14%           
=======================================
  Files        1424     1424           
  Lines       64924    64924           
  Branches     5936     5936           
=======================================
  Hits        28009    28009           
  Misses      35672    35672           
  Partials     1243     1243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Logo
Checkmarx One – Scan Summary & Details1c424edb-fd38-4bc8-8315-99abaa036533

No New Or Fixed Issues Found

@differsthecat differsthecat merged commit 0e32dcc into main Dec 4, 2024
52 checks passed
@differsthecat differsthecat deleted the pm-5550-totp-inline-menu-flag branch December 4, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants