Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15128] Add Promote Provider Service User functionality to Bitwarden Portal #5118

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Dec 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15128

📔 Objective

CS have the ability via the Bitwarden Portal to promote an organization “Admin” role to an “Owner” role. This is useful when a sole Owner locks themselves out of their account and they need to recover the org.

CS have requested a similar ability for the Provider Portal, i.e. a tool that lets them promote a Provider “Service User” role to a “Provider Admin” role.

📸 Screenshots

New tools menu navigation item:
image

Promote Provider Service User page:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 5, 2024

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
Promote Provider Service User Tool pm-15128-promote-provider-service-user-tool

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 42.90%. Comparing base (674e522) to head (01940e1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/Controllers/ToolsController.cs 0.00% 27 Missing ⚠️
src/Admin/Views/Shared/_Layout.cshtml 0.00% 6 Missing ⚠️
...rc/Admin/Models/PromoteProviderServiceUserModel.cs 0.00% 2 Missing ⚠️
src/Admin/Utilities/RolePermissionMapping.cs 0.00% 2 Missing ⚠️
...dmin/Views/Tools/PromoteProviderServiceUser.cshtml 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
- Coverage   42.92%   42.90%   -0.03%     
==========================================
  Files        1433     1435       +2     
  Lines       65668    65705      +37     
  Branches     6021     6030       +9     
==========================================
  Hits        28191    28191              
- Misses      36210    36247      +37     
  Partials     1267     1267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome requested a review from vincentsalucci December 5, 2024 16:28
@r-tome r-tome marked this pull request as ready for review December 5, 2024 16:28
@r-tome r-tome requested a review from a team as a code owner December 5, 2024 16:28
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Logo
Checkmarx One – Scan Summary & Details5caf8ca4-2e56-41f3-8ece-0bef21add8f8

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Missing_CSP_Header /util/Setup/Templates/DockerCompose.hbs: 18 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 372

Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks @r-tome!

@r-tome r-tome merged commit 9b47810 into main Dec 11, 2024
52 checks passed
@r-tome r-tome deleted the ac/pm-15128/add-promote-provider-service-user-functionality-to-bitwarden-portal branch December 11, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants