Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12273] Integration page #5119

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[PM-12273] Integration page #5119

merged 3 commits into from
Dec 10, 2024

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Dec 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12273

📔 Objective

Adds feature flag, adds endpoint to get organization plan type

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner December 5, 2024 16:44
@BTreston BTreston requested a review from JimmyVo16 December 5, 2024 16:44
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Logo
Checkmarx One – Scan Summary & Detailsce3d88bc-d420-4d0e-8f48-635b0213772f

No New Or Fixed Issues Found

@BTreston BTreston changed the title Ac/pm 12273 integration page [PM-12273] Integration page Dec 5, 2024
JimmyVo16
JimmyVo16 previously approved these changes Dec 6, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 42.92%. Comparing base (2212f55) to head (536e39c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...dminConsole/Controllers/OrganizationsController.cs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5119      +/-   ##
==========================================
- Coverage   42.92%   42.92%   -0.01%     
==========================================
  Files        1433     1433              
  Lines       65654    65662       +8     
  Branches     6020     6021       +1     
==========================================
  Hits        28184    28184              
- Misses      36205    36213       +8     
  Partials     1265     1265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BTreston BTreston merged commit 9c8f932 into main Dec 10, 2024
52 checks passed
@BTreston BTreston deleted the ac/pm-12273-integration-page branch December 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants