Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15833] Quartz Job Scoped Service Support #5131

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15833

📔 Objective

Updated quartz jobs to create a container scope to allow for scoped services

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team December 9, 2024 18:07
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.92%. Comparing base (c591997) to head (94f165d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Jobs/JobFactory.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
- Coverage   42.92%   42.92%   -0.01%     
==========================================
  Files        1433     1433              
  Lines       65653    65654       +1     
  Branches     6020     6020              
==========================================
  Hits        28184    28184              
- Misses      36204    36205       +1     
  Partials     1265     1265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Logo
Checkmarx One – Scan Summary & Details6548c2b3-1671-4a79-bb5a-714977254f7e

No New Or Fixed Issues Found

Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like the right place to do it to me.

I'd say the only thing really up for discussion is whether or not the scope of a job is the job itself or all jobs. Currently jobs are independent and I would like them to stay that way, which is the direction you're going here.

The quartz stuff is done pretty manually through the JobsHostedService and subclasses

@cturnbull-bitwarden cturnbull-bitwarden merged commit 2212f55 into main Dec 9, 2024
52 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-15833/login-errors branch December 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants