BRE-311 Fix the MsSqlMigratorUtility failing silently #5134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
=======================================
Coverage 42.93% 42.93%
=======================================
Files 1433 1433
Lines 65660 65660
Branches 6020 6020
=======================================
Hits 28190 28190
Misses 36205 36205
Partials 1265 1265 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
vgrassia
approved these changes
Dec 10, 2024
michalchecinski
deleted the
BRE-311-Fix-the-DB-migrator-tool-failing-silently
branch
vgrassia
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit 9e86010)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-311
📔 Objective
The DB Migrator tool will sometimes fail applying a SQL migration script, but the job will report success in the workflow causing the rest of the workflow to execute. When the migrator tool fails when applying a SQL migration script, it should fail the job and the workflow should reflect that accordingly.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes