Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6201] Fix creation of organizations no longer working after mergi… #5142

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jonashendrickx
Copy link
Member

…ng #5130

🎟️ Tracking

📔 Objective

Can no longer create new organizations after merging #5130

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner December 11, 2024 12:34
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.90%. Comparing base (09db6c7) to head (8669559).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Admin/AdminConsole/Models/OrganizationsModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5142   +/-   ##
=======================================
  Coverage   42.90%   42.90%           
=======================================
  Files        1435     1435           
  Lines       65705    65705           
  Branches     6030     6030           
=======================================
  Hits        28191    28191           
- Misses      36247    36248    +1     
+ Partials     1267     1266    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8a93fd09-ad94-4a17-9f00-af99d65d6299

No New Or Fixed Issues Found

@jonashendrickx jonashendrickx merged commit 64573d0 into main Dec 11, 2024
52 checks passed
@jonashendrickx jonashendrickx deleted the fix/pm-6201 branch December 11, 2024 13:56
jonashendrickx added a commit that referenced this pull request Dec 11, 2024
jonashendrickx added a commit that referenced this pull request Dec 11, 2024
* Revert "[PM-6201] Fix creation of organizations no longer working after merging #5130 (#5142)"

This reverts commit 64573d0.

* Revert "[PM-6201] Self-Host Admin Portal is reporting "10239 GB of Additional… (#5130)"

This reverts commit 674e522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants