Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14380] Add GET /tasks/organization endpoint #5149

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Dec 13, 2024

🎟️ Tracking

PM-14380

📔 Objective

Add the new GET /tasks/organization?organizationId=XXX&status=0 endpoint to the SecurityTasksController and the corresponding queries and sprocs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 38 lines in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (a99f82d) to head (de46c14).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ework/Vault/Repositories/SecurityTaskRepository.cs 0.00% 22 Missing ⚠️
...rc/Api/Vault/Controllers/SecurityTaskController.cs 0.00% 8 Missing ⚠️
...apper/Vault/Repositories/SecurityTaskRepository.cs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5149      +/-   ##
==========================================
- Coverage   43.78%   43.77%   -0.01%     
==========================================
  Files        1482     1483       +1     
  Lines       68471    68527      +56     
  Branches     6204     6206       +2     
==========================================
+ Hits        29977    29996      +19     
- Misses      37184    37221      +37     
  Partials     1310     1310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Logo
Checkmarx One – Scan Summary & Details1a0ca860-ba5f-4bed-be36-b4586d607f2b

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66 Attack Vector
MEDIUM Privacy_Violation /src/Core/AdminConsole/OrganizationAuth/UpdateOrganizationAuthRequestCommand.cs: 84 Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 173 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 202 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 527 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 200 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 972 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 220 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 75 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 87 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/TwoFactorController.cs: 406 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 61
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 470
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 371
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 121
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 80
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164

Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shane-melton shane-melton force-pushed the vault/pm-14380/list-organization-tasks-endpoint branch from ed9c14d to 0b9a2cd Compare December 13, 2024 19:01
gbubemismith
gbubemismith previously approved these changes Dec 13, 2024
@shane-melton shane-melton force-pushed the vault/pm-14380/list-organization-tasks-endpoint branch from 0b9a2cd to 09829b5 Compare December 16, 2024 19:58
@shane-melton shane-melton force-pushed the vault/pm-14380/list-organization-tasks-endpoint branch from 09829b5 to 7728367 Compare January 2, 2025 19:10
rkac-bw
rkac-bw previously approved these changes Jan 2, 2025
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shane-melton
Copy link
Member Author

Can be retargeted/merged after #5039 is merged

Base automatically changed from vault/pm-14378/security-task-auth-handler to main January 9, 2025 20:14
@shane-melton shane-melton dismissed stale reviews from rkac-bw and gbubemismith January 9, 2025 20:14

The base branch was changed.

@shane-melton shane-melton force-pushed the vault/pm-14380/list-organization-tasks-endpoint branch from 7728367 to de46c14 Compare January 9, 2025 20:19
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shane-melton shane-melton merged commit 0605590 into main Jan 9, 2025
55 checks passed
@shane-melton shane-melton deleted the vault/pm-14380/list-organization-tasks-endpoint branch January 9, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants