[PM-12994] Check for New Device Verification Exception #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added constant to constants in Bit.Core because the cache key format needs to be shared between the Identity Server and the MVC project Admin. Updated DeviceValidator class to handle checking cache for user information to allow pass through. Updated and Added tests to handle new flow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5153 +/- ##
=======================================
Coverage 42.99% 42.99%
=======================================
Files 1446 1446
Lines 66143 66155 +12
Branches 6059 6060 +1
=======================================
+ Hits 28437 28446 +9
- Misses 36424 36426 +2
- Partials 1282 1283 +1 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Patrick-Pimentel-Bitwarden
approved these changes
Dec 17, 2024
ike-kottlowski
deleted the
auth/pm-12994/add-cache-check-for-new-device-verification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12994
📔 Objective
We need to support the exception flow for Customer Success. This adds a check to the cache that Customer Success manages.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes