Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SH Unified Build trigger #5154

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Dec 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-499

📔 Objective

  • Unified build trigger needs the is_workflow_call input, even though the GH API trigger is a Workflow Dispatch

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner December 16, 2024 13:50
@Eeebru Eeebru requested a review from coroiu December 16, 2024 13:50
@michalchecinski
Copy link
Contributor

michalchecinski commented Dec 16, 2024

Please, wait for bitwarden/self-host#327 to be merged.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.98%. Comparing base (9321515) to head (3ee1f79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5154   +/-   ##
=======================================
  Coverage   42.98%   42.98%           
=======================================
  Files        1446     1446           
  Lines       66150    66150           
  Branches     6060     6060           
=======================================
  Hits        28437    28437           
  Misses      36431    36431           
  Partials     1282     1282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eeebru Eeebru enabled auto-merge (squash) December 16, 2024 14:08
@Eeebru Eeebru merged commit d0c72a3 into main Dec 16, 2024
52 checks passed
@Eeebru Eeebru deleted the BRE-499-update-sh-trigger-on-server branch December 16, 2024 14:21
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Details1dc1cf78-a897-4ee8-a834-b09b039742b8

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build.yml: 601 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 638 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 686 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build.yml: 600
LOW Unpinned Actions Full Length Commit SHA /build.yml: 685
LOW Unpinned Actions Full Length Commit SHA /build.yml: 637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants