Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15091] Removing access intelligence server side feature flag #5158

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ttalty
Copy link
Contributor

@ttalty ttalty commented Dec 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13232

📔 Objective

Removing the unnecessary AccessIntelligence feature flag key from the server. PM-15091 creates a feature flag in the bitwarden portal.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ttalty ttalty self-assigned this Dec 16, 2024
@ttalty ttalty requested a review from a team December 16, 2024 17:49
Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Access intelligence pm-13227-access-intelligence ✅ all references removed

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.00%. Comparing base (d88a103) to head (f52da99).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   43.00%   43.00%           
=======================================
  Files        1447     1447           
  Lines       66164    66164           
  Branches     6062     6062           
=======================================
  Hits        28455    28455           
  Misses      36427    36427           
  Partials     1282     1282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details9d77d589-b0b1-4501-a39e-5a972b5ec6b7

No New Or Fixed Issues Found

@ttalty ttalty merged commit a3da5b2 into main Dec 19, 2024
52 checks passed
@ttalty ttalty deleted the tools/pm-13232/remove-server-feature-flag branch December 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants