Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authenticator sync flags #5159

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

differsthecat
Copy link
Member

📔 Objective

Add Authenticator Sync feature flags

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

LaunchDarkly flag references

🔍 2 flags added or modified

Name Key Aliases found Info
Android Authenticator Sync enable-authenticator-sync-android
iOS Authenticator Sync enable-authenticator-sync-ios

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7637cbe). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5159   +/-   ##
=======================================
  Coverage        ?   43.17%           
=======================================
  Files           ?     1451           
  Lines           ?    66239           
  Branches        ?     6070           
=======================================
  Hits            ?    28601           
  Misses          ?    36352           
  Partials        ?     1286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsa71a0ad7-9a11-4233-b980-2bee92f78b3c

No New Or Fixed Issues Found

@differsthecat differsthecat merged commit b907935 into main Dec 16, 2024
52 checks passed
@differsthecat differsthecat deleted the authenticator-sync-feature-flags branch December 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants