Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-500] Remove is_workflow_call input from build workflow #5161

Merged

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-500

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner December 17, 2024 13:20
@michalchecinski michalchecinski requested review from justindbaur and a team December 17, 2024 13:20
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.17%. Comparing base (b907935) to head (76ca7e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5161   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files        1451     1451           
  Lines       66239    66239           
  Branches     6070     6070           
=======================================
  Hits        28601    28601           
  Misses      36352    36352           
  Partials     1286     1286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details563ab455-b09d-4243-9309-439110acef30

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build.yml: 637 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 685 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 600 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build.yml: 686
LOW Unpinned Actions Full Length Commit SHA /build.yml: 638
LOW Unpinned Actions Full Length Commit SHA /build.yml: 601

@michalchecinski michalchecinski enabled auto-merge (squash) December 17, 2024 14:06
@michalchecinski michalchecinski merged commit 1648809 into main Dec 17, 2024
52 checks passed
@michalchecinski michalchecinski deleted the BRE-500-Update-SH-Unified-Builds-to-use-trigger-check branch December 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants