[PM-12995] Create UI elements for New Device Verification in Admin Portal #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added constant to constants in Bit.Core because the cache key format needs to be shared between the Identity Server and the MVC project Admin. Updated DeviceValidator class to handle checking cache for user information to allow pass through. Updated and Added tests to handle new flow.
… Added tests for new methods in UserService.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5165 +/- ##
=======================================
Coverage 43.16% 43.16%
=======================================
Files 1452 1452
Lines 66299 66341 +42
Branches 6073 6079 +6
=======================================
+ Hits 28615 28635 +20
- Misses 36396 36418 +22
Partials 1288 1288 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Patrick-Pimentel-Bitwarden
approved these changes
Dec 18, 2024
| @@ -44,6 +47,8 @@ public UserEditModel( | |||
| public string RandomLicenseKey => CoreHelpers.SecureRandomString(20); | |||
| public string OneYearExpirationDate => DateTime.Now.AddYears(1).ToString("yyyy-MM-ddTHH:mm"); | |||
| public string BraintreeMerchantId { get; init; } | |||
| public bool ActiveNewDeviceVerificationException { get; init; } | |||
|
|
|||
There was a problem hiding this comment.
Nitpick, extra line here
| Device Verification</button> | ||
| } | ||
| </form> | ||
|
|
There was a problem hiding this comment.
Nitpick, extra line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12995
📔 Objective
If a user is locked out of their email which would be used for new device verification, we want to allow a way for Customer Success to allow an exception, so the user is not locked out of their account accidently.
📸 Screenshots
Exception Process
msedge_61PPOhnNwW.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes