Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to missing file #5166

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove link to missing file #5166

merged 1 commit into from
Dec 18, 2024

Conversation

withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Randomly noticed.

๐Ÿ“” Objective

Removes a reference to NuGet.config which we got rid of a while ago.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review December 18, 2024 20:18
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 43.35%. Comparing base (322a074) to head (20d57bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5166   +/-   ##
=======================================
  Coverage   43.35%   43.35%           
=======================================
  Files        1456     1456           
  Lines       66468    66468           
  Branches     6078     6078           
=======================================
  Hits        28817    28817           
  Misses      36360    36360           
  Partials     1291     1291           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 14601bce-0525-42fc-8ace-3fa9ad2712c8

No New Or Fixed Issues Found

@withinfocus withinfocus merged commit 4f50461 into main Dec 18, 2024
52 checks passed
@withinfocus withinfocus deleted the config-missing branch December 18, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants