Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Duende license from renewal #5169

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update Duende license from renewal #5169

merged 1 commit into from
Dec 19, 2024

Conversation

withinfocus
Copy link
Contributor

🎟️ Tracking

Internal change from a contract renewal.

📔 Objective

Updates the Duende license key based on what they gave us.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review December 19, 2024 18:11
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.35%. Comparing base (a3da5b2) to head (ffa6e4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5169   +/-   ##
=======================================
  Coverage   43.35%   43.35%           
=======================================
  Files        1456     1456           
  Lines       66468    66468           
  Branches     6078     6078           
=======================================
  Hits        28817    28817           
  Misses      36360    36360           
  Partials     1291     1291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Logo
Checkmarx One – Scan Summary & Details1ecb5bbc-00e1-4b0f-8be7-161aec4eeed9

No New Or Fixed Issues Found

@withinfocus withinfocus merged commit eb7454b into main Dec 19, 2024
52 checks passed
@withinfocus withinfocus deleted the duende-license branch December 19, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants