[pm-5966] Fix Entity Framework query for MySQL#5170
Merged
Conversation
JimmyVo16
commented
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5170 +/- ##
==========================================
+ Coverage 43.34% 43.69% +0.34%
==========================================
Files 1458 1469 +11
Lines 66517 67870 +1353
Branches 6081 6148 +67
==========================================
+ Hits 28835 29658 +823
- Misses 36390 36919 +529
- Partials 1292 1293 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
New Issues
Fixed Issues
|
r-tome
requested changes
Dec 20, 2024
Contributor
r-tome
left a comment
r-tome
left a comment
There was a problem hiding this comment.
It looks good to me but it would be ideal to have the integration test
Contributor
|
Looks like this should resolve #3722. Funny to see it resolved because of a compilation issue vs. the longstanding pre-existing issue. |
JimmyVo16
commented
Dec 20, 2024
r-tome
previously approved these changes
Jan 2, 2025
- Replace incorrect models to simplify compatibility with the stored proc. - Fix logic issues and update tests to ensure consistency between stored proc and Entity Framework.
r-tome
approved these changes
Jan 6, 2025
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-5966
📔 Objective
Problem: The Entity Framework query was causing a compile-time error.
Changes:
📸 Screenshots
Manual testing
Generated SQL query.
With results
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes