Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate: Assign DbOps to Microsoft.Extensions.Caching.Cosmos #5171

Merged

Conversation

djsmith85
Copy link
Contributor

📔 Objective

Seeing that #4721 has no reviewer/owner attached I looked for an good owner. As Microsoft.Extensions.Caching.SqlServer is already assigned to DbOps, I opted to also assign them caching for Cosmos.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team December 20, 2024 12:58
@djsmith85 djsmith85 enabled auto-merge (squash) December 20, 2024 12:58
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.35%. Comparing base (cb7cbb6) to head (d594e38).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5171   +/-   ##
=======================================
  Coverage   43.35%   43.35%           
=======================================
  Files        1456     1456           
  Lines       66468    66468           
  Branches     6078     6078           
=======================================
  Hits        28817    28817           
  Misses      36360    36360           
  Partials     1291     1291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse27c7a66-7bf5-426a-8089-816c98a5c1ae

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/FreshdeskController.cs: 44 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 173
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 202

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@djsmith85 djsmith85 merged commit 11325c4 into main Dec 20, 2024
52 checks passed
@djsmith85 djsmith85 deleted the assign-ownership-to-Microsoft.Extensions.Caching.Cosmos branch December 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants