Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14894] Drop Tax Rate tables - Stage 1 #5236

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[PM-14894] Drop Tax Rate tables - Stage 1 #5236

merged 1 commit into from
Jan 10, 2025

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jan 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14894

📔 Objective

The tax rates are no longer stored in the database as we now rely on Stripe. This pull request will prepare allowing us to drop the tables and removes all relevant screens in the admin portal.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 9, 2025 13:12
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.94%. Comparing base (f265911) to head (dfe33b0).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/Admin/Views/Shared/_Layout.cshtml 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5236      +/-   ##
==========================================
+ Coverage   43.75%   43.94%   +0.19%     
==========================================
  Files        1476     1469       -7     
  Lines       68146    67831     -315     
  Branches     6172     6132      -40     
==========================================
- Hits        29816    29808       -8     
+ Misses      37032    36726     -306     
+ Partials     1298     1297       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsf9b6f3d3-5854-4506-8f38-4d936e04c39e

No New Or Fixed Issues Found

@jonashendrickx jonashendrickx merged commit 45d2c53 into main Jan 10, 2025
56 checks passed
@jonashendrickx jonashendrickx deleted the PM-14894 branch January 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants