Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15547] Fix two-factor authentication revocation logic and update related tests #5246

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jan 10, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15547

📔 Objective

Update 2FA disabling logic to revoke all users (independently if they're managed or not) and send out notification emails.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome requested a review from jrmccannon January 10, 2025 12:34
@r-tome r-tome marked this pull request as ready for review January 10, 2025 12:34
@r-tome r-tome requested a review from a team as a code owner January 10, 2025 12:34
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.77%. Comparing base (8a68f07) to head (b4474f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5246      +/-   ##
==========================================
- Coverage   43.77%   43.77%   -0.01%     
==========================================
  Files        1483     1483              
  Lines       68566    68565       -1     
  Branches     6211     6211              
==========================================
- Hits        30016    30015       -1     
  Misses      37242    37242              
  Partials     1308     1308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details71bbfbeb-fd25-43e5-8441-056da02c2574

No New Or Fixed Issues Found

@r-tome r-tome merged commit fbfabf2 into main Jan 10, 2025
53 checks passed
@r-tome r-tome deleted the ac/pm-15547/disabling-two-factor-should-revoke-managed-user-when-policy-enabled branch January 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants