[PM-25182] Improve Swagger OperationIDs for Vault

[dani-garcia]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25182

📔 Objective

This PR is a continuation of the work started in #6229, with some of the team specific changes split out for easier review/merge. You can read that PR for a more complete explanation of the purpose, but in short:

• The SDK generates bindings from the Swagger specification, which creates function names in the format HTTP path + HTTP method. This leads to very unwieldy names.
• Our goal is to instead generate function names that match the functions in the controller, which means we can't have duplicate overloaded function names, and we can't have more than one route per function.

To fullfill those two goals, this PR does two things:

• If there are two functions with the same name in a controller, I've renamed one of them to be more descriptive.
• If a function has two route attributes, I've moved one of the route attributes to a new function and marked it as Obsolete. In general I tried to mark the less precise HTTP method as obsolete. I will leave it up to each team to evaluate if the obsolete routes can be deleted or if they should be maintained.

The final result in the SDK will look like this:

// The current function for GET {}/organizations/{id}/access-policies/people/potential-grantees
pub async fn organizations_id_access_policies_people_potential_grantees_get(...) {}

// Once all these PRs are merged, the name will be
pub async fn get_people_potential_grantees() {}

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.14%. Comparing base (e456b4c) to head (a18d063).

Files with missing lines	Patch %	Lines
src/Api/Vault/Controllers/CiphersController.cs	0.00%	48 Missing ⚠️
src/Api/Vault/Controllers/FoldersController.cs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6240      +/-   ##
==========================================
- Coverage   49.17%   49.14%   -0.04%     
==========================================
  Files        1782     1782              
  Lines       79298    79352      +54     
  Branches     7045     7045              
==========================================
  Hits        38997    38997              
- Misses      38782    38836      +54     
  Partials     1519     1519              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – fe8ebd22-3c48-42ed-8ae3-e08720c0163a

New Issues (5)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1317	details Method at line 1317 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: 7rnKZR98mlzWAxhAWSFK68y4o3w%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1317	details Method at line 1317 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: Kjyf8kn6ICbR%2BuKEFWUQMj8uQao%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1317	details Method at line 1317 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: NOND4tzAfY0vskTjDfPIew6mCV8%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1411	details Method at line 1411 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: Ms%2BYc5x%2FZE98hmPFbHl3fSmt3lc%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1292	details Method at line 1292 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: 3FrMTkH791Ap%2BM6Y1VMjZ1G%2BgVM%3D Attack Vector

Fixed Issues (5)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Controllers/CollectionsController.cs: 176
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1233
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1233
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1233
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 278

[sonarqubecloud]

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud