Skip to content

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24557

📔 Objective

This PR removes the pm-21881-manage-payment-details-outside-checkout feature flag and all associated endpoints, methods and models that are no longer used as a result.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.51%. Comparing base (53e5ddb) to head (0c28dd0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6247      +/-   ##
==========================================
+ Coverage   49.34%   49.51%   +0.16%     
==========================================
  Files        1782     1774       -8     
  Lines       78848    78528     -320     
  Branches     7012     6980      -32     
==========================================
- Hits        38910    38883      -27     
+ Misses      38423    38131     -292     
+ Partials     1515     1514       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Aug 25, 2025

Logo
Checkmarx One – Scan Summary & Details5e21e697-bf3d-4f64-9fe0-0ead0b5c0daf

Great job! No new security vulnerabilities introduced in this pull request

@amorask-bitwarden amorask-bitwarden marked this pull request as ready for review August 25, 2025 18:38
@amorask-bitwarden amorask-bitwarden requested review from a team as code owners August 25, 2025 18:38
Copy link

sonarqubecloud bot commented Sep 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants