Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating the initial draft of the Secrets Manager K8s operator project #3

Merged
merged 22 commits into from
Mar 18, 2024
Merged

Creating the initial draft of the Secrets Manager K8s operator project #3

merged 22 commits into from
Mar 18, 2024

Conversation

jhbeskow
Copy link
Contributor

@jhbeskow jhbeskow commented Mar 5, 2024

🎟️ Tracking

🚧 Type of change

  • 🚀 New feature development

📔 Objective

Initial creation of the Secrets Manager K8s operator to sync secrets from SM to namespaces in Kubernetes.

📋 Code changes

  • src/sm-operator/* -- Added the code for the operator using operator-sdk.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

@jhbeskow
Adding support .vscode files to the repo. Setting up Dockerfile and M…
51fcbf3 
…akefile temporarily for local build until SDK binary pull is setup.
@jhbeskow jhbeskow marked this pull request as ready for review March 6, 2024 16:14
@jhbeskow jhbeskow requested a review from a team as a code owner March 6, 2024 16:14
tangowithfoxtrot
tangowithfoxtrot reviewed Mar 7, 2024
View reviewed changes
src/sm-operator/README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/sm-operator/Dockerfile Show resolved Hide resolved
src/sm-operator/Makefile Show resolved Hide resolved
Thomas-Avery
Thomas-Avery requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few minor things to take a look at.

README.md Outdated Show resolved Hide resolved
src/sm-operator/.vscode/extensions.json Outdated Show resolved Hide resolved
src/sm-operator/.vscode/launch.json Outdated Show resolved Hide resolved
src/sm-operator/.vscode/tasks.json Outdated Show resolved Hide resolved
src/sm-operator/api/v1/bitwardensecret_types.go Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
Thomas-Avery
Thomas-Avery requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the main flow looked good, thank you!

One minor code thing and one question about how these configuration files were generated/edited.

src/sm-operator/config/default/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved
src/sm-operator/internal/controller/bitwardensecret_controller.go Outdated Show resolved Hide resolved
@jhbeskow jhbeskow requested a review from Thomas-Avery March 15, 2024 21:45
Thomas-Avery
Thomas-Avery approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhbeskow jhbeskow merged commit 2214550 into main Mar 18, 2024
1 check passed
@jhbeskow jhbeskow deleted the features/operator_creation_repair branch March 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Avery Thomas-Avery Thomas-Avery approved these changes

@differsthecat differsthecat Awaiting requested review from differsthecat

@maxkpower maxkpower Awaiting requested review from maxkpower

@coltonhurst coltonhurst Awaiting requested review from coltonhurst

@tangowithfoxtrot tangowithfoxtrot Awaiting requested review from tangowithfoxtrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhbeskow @tangowithfoxtrot @Thomas-Avery