Features/build2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhbeskow
commented
Mar 25, 2024
…tion. Some improvements around .devcontainer support
…ld. Fixing a time-based error in some of the tests.
…compatiblity with VS Code "Testing" and static binaries
| @@ -6,6 +6,13 @@ import ( | |||
| "github.com/bitwarden/sdk/languages/go/internal/cinterface" | |||
| ) | |||
|
|
|||
| type BitwardenClientInterface interface { | |||
There was a problem hiding this comment.
Just flagging these as things we'll need to reconcile with the SDK repo.
| @@ -7,7 +7,8 @@ import ( | |||
|
|
|||
| /* | |||
| #cgo LDFLAGS: -lbitwarden_c | |||
| #cgo linux LDFLAGS: -L/usr/local/lib -L/usr/lib -L ./lib | |||
| #cgo LDFLAGS: -Wl,-unresolved-symbols=ignore-all | |||
There was a problem hiding this comment.
Same here. We'll need to consider pushing these flags to what's in the SDK repo, or see if there's a way to move them into the Makefile in the future.
tangowithfoxtrot
approved these changes
Mar 28, 2024
…to target Go 1.22 and higher. Operator SDK is not currently compatible with Go 1.22.
Thomas-Avery
requested changes
Mar 29, 2024
Co-authored-by: Thomas Avery <[email protected]>
joseph-flinn
reviewed
Apr 1, 2024
joseph-flinn
reviewed
Apr 1, 2024
joseph-flinn
approved these changes
Apr 1, 2024
Thomas-Avery
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
🚧 Type of change
📔 Objective
📋 Code changes
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes