Add a macro that allows not including STB's impl. #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for projects that want to use bgfx's imgui layer but supply their own STB implementation that would otherwise conflict with this one (due to them being global C functions).
|
I dislike this approach, but understand what's the problem... Also bgfx doesn't use #ifdef/#ifndef rather uses defines that are set to 0 or 1. |
Any suggestions on how to implement this nicely? |
Not really right now. I would have to look at it to refresh my memory why it's done like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for projects that want to use bgfx's imgui layer but supply their own STB implementation that would otherwise conflict with this one (due to them being global C functions).