Renew access & refresh token on expiration #63 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hupf
commented
Nov 7, 2023
caebr
approved these changes
Nov 8, 2023
hupf
force-pushed
the
feature/63-token-renewal
branch
from
dae88ba to
4600fb0
Compare
|
@caebr Ich habe das Starten des Refresh Token Timers, wenn schon ein Token da ist noch hinzugefügt. Ausserdem habe ich Logging Helpers gemacht, welche nur im Dev Mode loggen. So könne wir die expire Time rausloggen... dabei habe ich auch das ganze Auth-Logging auf diese Helpers umgestellt. |
hupf
force-pushed
the
feature/63-token-renewal
branch
3 times, most recently
from
c8a65e3 to
f177fbc
Compare
hupf
force-pushed
the
feature/63-token-renewal
branch
2 times, most recently
from
dc2ffc0 to
d0c5097
Compare
hupf
force-pushed
the
feature/63-token-renewal
branch
from
d0c5097 to
ea0b7aa
Compare
|
@caebr Ich habe auf diesem Branch das Refactoring auf die TokenState Facade gemacht. Das Token Renewal basiert nun darauf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caebr Ich habe das Token Renewal implementiert und lokal mit kürzeren Zeiten getestet. Werde es aber noch mit der vollen Token-Gültigkeitsdauer testen.