[Bert] Feature: Custom Model Outputs #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonkle
force-pushed
the
feature/22-custom-bert-model-outputs
branch
3 times, most recently
from
75e57fc
to
74930eb
Compare
bkonkle
force-pushed
the
feature/22-custom-bert-model-outputs
branch
from
a860d95
to
5d3c24a
Compare
bkonkle
force-pushed
the
feature/22-custom-bert-model-outputs
branch
2 times, most recently
from
1c5977f
to
06b188b
Compare
bkonkle
changed the title
nathanielsimard
suggested changes
May 6, 2024
bert-burn/src/model.rs
Outdated
| } | ||
|
|
||
| impl BertModelConfig { | ||
| /// Initializes a Bert model with default weights | ||
| pub fn init<B: Backend>(&self, device: &B::Device) -> BertModel<B> { | ||
| let embeddings = BertEmbeddingsConfig { | ||
| pub fn init<B: Backend>(&self, device: &B::Device, with_pooling_layer: bool) -> BertModel<B> { |
There was a problem hiding this comment.
I think I would put the pooling_layer in the config.
There was a problem hiding this comment.
👍 I went back and forth on it, and I ended up going in this direction because I reasoned that this was a Burn-specific modifier rather than an actual model config parameter. I can see how it's more obvious in the config, though, so that distinction doesn't really matter. 😄 I'll make the change, and stage the PR against the tracel-ai repo for final review. Thanks for taking a look!
bkonkle
force-pushed
the
feature/22-custom-bert-model-outputs
branch
from
55315ba
to
605f98b
Compare
|
Closing this PR in favor of one targeting the upstream repo: tracel-ai#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.