Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14기 팝콘] Step2 상태 관리로 메뉴 관리하기 #284

Open
wants to merge 10 commits into
base: yeomgahui
Choose a base branch
from
Open

[14기 팝콘] Step2 상태 관리로 메뉴 관리하기 #284

wants to merge 10 commits into from
+190 −3

Commits on Jul 11, 2022

  1. Update README.md

    @yeomgahui
    yeomgahui authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    7a9b5f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. step1 구현완료

    @yeomgahui
    yeomgahui committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    23d265d View commit details
    Browse the repository at this point in the history

  2. [14기 팝콘] Step1 Comment 추가 

    STEP 1 구현을 마쳤습니다.

개인적으로 구현하면서 아쉬웠던 부분을 생각해보면,

menu 추가시 수정 삭제를 위해 addEventListener를 등록 하는데, 메뉴 하나를 추가할때마다 모든 추가, 삭제 버튼의 eventListener를 다시 등록하도록 구현했습니다. => 개인적으로는 하나 추가할때마다 해당 수정, 삭제 버튼의 eventLIstener만을 추가하도록 하고 싶었는데 좋은 방법이 떠오르지 않았습니다.
JavaScript 파일을 기능 마다 분리하여서 작성하고 싶었는데, 어떻게 나눌지 모르곘어서 index.js 파일 내에 모든 로직을 다 작성했습니다. 이부분은 차차 다시 생각해보고 수정해보고 싶습니다.
    @yeomgahui
    yeomgahui authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    35ff482 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. test

    @yeomgahui
    yeomgahui committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    edeb882 View commit details
    Browse the repository at this point in the history

  2. test

    @yeomgahui
    yeomgahui committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    78bb9a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. test

    @yeomgahui
    yeomgahui committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    5633fd6 View commit details
    Browse the repository at this point in the history

  2. 필요없는 파일 제거

    @yeomgahui
    yeomgahui committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    08ce485 View commit details
    Browse the repository at this point in the history

  3. [14기 팝콘] 코드리뷰 후 수정

    @yeomgahui
    yeomgahui committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c5c42be View commit details
    Browse the repository at this point in the history

  4. [Step 1] 필요없는 주석 제거

    @yeomgahui
    yeomgahui committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c34f1ca View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. [14기 팝콘] step2 구현

    @yeomgahui
    yeomgahui committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    9e564b1 View commit details
    Browse the repository at this point in the history