Feature/vid pid map wildcard#1585
Merged
dragonmux merged 4 commits intoblackmagic-debug:mainfrom Aug 3, 2023
Merged
Conversation
49c7dc4 to
abd88ac
Compare
dragonmux
approved these changes
Aug 2, 2023
Member
There was a problem hiding this comment.
LGTM, that's some nice work figuring out how the J-Link PIDs work!
We'll test this locally across BMP, ORBTrace, Tigard and a couple of kinds of ST-Link but this looks good so we don't expect any problems. We'll merge it as soon as we've done some testing on it.
Edit: one small problem that needs sorting, please prefix the commit messages with hosted/ as these are all in the BMDA platform
Integrate product id "wildcard" in vid pid map search
This information was extracted from the Jlink software suite for linux udev rules
abd88ac to
0ab70a4
Compare
dragonmux
approved these changes
Aug 2, 2023
Member
|
This all seems to function correctly, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
Refactor done while rebasing #1399 which added a new probe type with no specified PID
While looking at this I got sidetracked into looking into the J-Link PIDs, discovering they have a whole meaning behind them, it seems they use them to list the USB Class interfaces the probe will have. I added this information to the protocol header, along with the masks and offsets required to interpret them, but did not implement anything with them, I don't think there's much value in parsing it for now, but might be useful later and serves at least as documentation
Test after the change:
Your checklist for this pull request
It builds for hardware native (make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues