This repository was archived by the owner on Mar 7, 2026. It is now read-only.
crc32: Buffer up log output to avoid prefix-chunking, fix func - #1998
Merged
Conversation
xobs
reviewed
Nov 11, 2024
Contributor
|
I like this change! It improves readability when doing checksum benchmarking. |
ALTracer
force-pushed
the
fix/crc32-snprintf
branch
from
November 11, 2024 06:29
8204569 to
ef1c2ab
Compare
Member
|
Please could you rebase this on |
ALTracer
force-pushed
the
fix/crc32-snprintf
branch
from
July 26, 2025 15:42
ef1c2ab to
7f93994
Compare
dragonmux
reviewed
Jul 26, 2025
dragonmux
left a comment
Member
There was a problem hiding this comment.
Couple of notes in doing a review - but with them fixed, this looks basically ready to merge. Good job!
ALTracer
force-pushed
the
fix/crc32-snprintf
branch
2 times, most recently
from
July 26, 2025 18:48
f48b77d to
5424dc1
Compare
dragonmux
approved these changes
Jul 27, 2025
dragonmux
left a comment
Member
There was a problem hiding this comment.
This LGTM, merging. Thank you for the contribution!
While there's a known issue with 64-bit targets here, we're not going to have this block merging this as that's a separate issue that'll take a pile more work to fix and so should be a separate PR.
* Format the optional output pieces into a stack buffer, then do a single DEBUG_INFO() call * Restore the name of compiled function implementation in the log output * Avoid dividing by 0 milliseconds elapsed
ALTracer
force-pushed
the
fix/crc32-snprintf
branch
from
July 27, 2025 14:17
5424dc1 to
0ac0c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
compare-sectionsviaqCRC.__func__portion of log became identical as collateral damage. This change restores the behaviour intended in Fix: qCRC performance uplift #1708, so that we can tell apart speed reports from BMF+ENABLE_DEBUGand BMDA.DEBUG_INFO()call etc. by prepending loglevel and timestamp, so the 2-3 piece logmessage gets broken and mixed. This change buffers the optional output pieces into a zeroed stack buffer viasnprintf()to avoid that.Your checklist for this pull request
Closing issues
Fixes some issues in Farpatch.