This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix JTAG sanity check in BYPASS device counting - #2178
Merged
Conversation
ALTracer
force-pushed
the
fix/jtag-bypass-count
branch
3 times, most recently
from
January 26, 2026 16:02
50aef39 to
177362b
Compare
Contributor
Author
|
Logs with a FT2232H-attached board (unsupported) on this branch. Please state whether I should keep or discard the $ ./build/blackmagic -tjv 1 -c ftdijtag
Black Magic Debug App v2.0.0-304-g11bd1f2c
for Black Magic Probe, ST-Link v2 and v3, CMSIS-DAP, J-Link, FTDI (MPSSE) and WCH-Link
Using 0403:6010 <no serial number> FTDI
Dual RS232-HS ---
Running in Test Mode
Target voltage: Unknown
Speed set to 3.750MHz for JTAG
Resetting TAP
Change state to Shift-DR
Scanning out ID codes
Return to Run-Test/Idle
Change state to Shift-IR
Scanning out IRs
Return to Run-Test/Idle
Change state to Shift-DR
jtag_scan: DR=1 by default in BYPASS
Return to Run-Test/Idle
ID code 0x000006df: Unknown
Given target number 1 not available max 0 |
Member
|
You've been able to prove the purpose of this PR with that message but we don't think it adds anything to scans more generally, so please drop the extra logging message. |
ALTracer
force-pushed
the
fix/jtag-bypass-count
branch
from
January 26, 2026 16:17
177362b to
54ddc35
Compare
dragonmux
approved these changes
Jan 26, 2026
dragonmux
left a comment
Member
There was a problem hiding this comment.
LGTM, merging - thank you for this fix to the BYPASS check so it's more correct and doesn't kick out devices that start with their DR BYPASS bit set to 1 after reset or previous scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
jtag_scan: Sanity check failed: BYPASS dev count doesn't match IR scanNot tested yet. The error/warning demotion will be rebased away once I confirm the solution works.
Upd: tested to improve the situation, the chip in question became scannable by BMF. Sanity check restored.
Your checklist for this pull request
Closing issues