Feature: implementation of jtagtap_cycle() for FTDI backend#2181
Merged
dragonmux merged 4 commits intoblackmagic-debug:mainfrom Feb 2, 2026
Merged
Feature: implementation of jtagtap_cycle() for FTDI backend#2181dragonmux merged 4 commits intoblackmagic-debug:mainfrom
jtagtap_cycle() for FTDI backend#2181dragonmux merged 4 commits intoblackmagic-debug:mainfrom
Conversation
Member
|
Please rebase this PR on |
a1fe471 to
74a11ed
Compare
dragonmux
reviewed
Jan 29, 2026
Member
dragonmux
left a comment
There was a problem hiding this comment.
Couple of review notes, nothing too major though and with them addressed we'll be happy to merge this.
Contributor
Author
|
Your questions made me realize I've designed this with a logic bug, where it commands 0x8e 0xff when 8 clocks are requested; should be 0x8e 0x07 or 0x8f 0x00. Confirmed with a small throwaway unit test snippet. |
Contributor
Author
4540bd5 to
c4549be
Compare
c4549be to
e4ae916
Compare
e4ae916 to
f9e0169
Compare
dragonmux
approved these changes
Feb 2, 2026
Member
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging. Thank you for the contribution and this speed-up to the FTDI code for running cycles where TMS and TDI need to be kept constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
jtagtap_cycle()sometimes, but BMDA hasn't always provided it.Tested on FT2232HL against a RISC-V MCU. Based on #2179. See #2180 for tracking other backends.
I would like some explanation, is buffering beneficial in the handlers, or does it exist externally (between two flush calls), then I can discard the 2nd commit.
Your checklist for this pull request
Closing issues