Feature: libwdi v1.5.1 update #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 319 319
Branches 319 319
=====================================
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esden
approved these changes
Sep 30, 2025
Member
esden
left a comment
esden
left a comment
There was a problem hiding this comment.
LGTM, I assume the bindgen update will happen separately when needed?
In that case I will merge this.
Member
Author
|
Yeah, especially as this all seems to work as-is right now. We'll re-run Bindgen as a separate step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update libwdi to bring in the latest fixes and improvements from upstream, and update the Rust dependencies to keep those ticking over properly. This should allow a v0.1.3 release to be done with the fixes and improvements PR'd in on #12 and with all the build flow fixes in #14.
The
bindgenbindings should probably be refreshed, but no major API changes have occurred in libwdi that we can tell, so this isn't a pressing matter.