Update dock.go

blacktop · Sep 15, 2023 · 5159077 · 5159077
1 parent 4452130
commit 5159077
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/internal/dock/dock.go b/internal/dock/dock.go
@@ -273,25 +273,21 @@ func (p *Plist) Save() error {
 		return fmt.Errorf("failed to backup plist: %w", err)
 	}
 
-	jdat, err := p.AsJSON()
-	if err != nil {
-		return fmt.Errorf("failed to marshal plist to json: %w", err)
-	}
-	utils.Indent(log.Debug, 3)(fmt.Sprintf("dock plist: %s", string(jdat)))
-
 	// write dock plist to temp file
-	tmp, err := os.Create("/tmp/dock.plist")
+	tmp, err := os.CreateTemp("", "dock.plist")
 	if err != nil {
 		return fmt.Errorf("failed to create temp file: %v", err)
 	}
-	utils.Indent(log.WithField("plist", "/tmp/dock.plist").Info, 3)("writing temp dock plist")
+	defer os.Remove(tmp.Name())
+
+	utils.Indent(log.WithField("plist", tmp.Name()).Info, 3)("writing temp dock plist")
 	if err := plist.NewBinaryEncoder(tmp).Encode(p); err != nil {
 		return fmt.Errorf("failed to decode plist: %w", err)
 	}
 	tmp.Close()
 
 	// import plist and restart dock
-	if err := p.importPlist("/tmp/dock.plist"); err != nil {
+	if err := p.importPlist(tmp.Name()); err != nil {
 		return fmt.Errorf("failed to import plist: %w", err)
 	}
 	return p.kickstart()