Fix CRT shader for Pixel/Other devices - #212
Open
siameseneko-dev wants to merge 5 commits into
Open
Conversation
Fixes CRT by commenting out the noise shader.
|
i've tested it and, the core cause looks like pixel's gpu MY_HIGHP_OR_MEDIUMP number x = (tc.x - mod(tc.x, 0.002)) * (tc.y - mod(tc.y, 0.0013)) * time * 1000.0;to MY_HIGHP_OR_MEDIUMP number x = (tc.x - 0.002 * fract(tc.x / 0.002)) * (tc.y - 0.0013 * fract(tc.y / 0.0013)) * time * 1000.0;works fine on my pixel 9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the noise part of the shader.
I isolated it as the cause of the black void, also fixes the game looking desaturated.