Support GOES-19 #111
Merged
Support GOES-19 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added tests in test_GOES.py * in practice only tried to generate RGB TrueColor and it worked
|
This is great! I just left one comment for now, then I'll merge. |
|
Thanks, and great work! Where did you leave that comment? |
|
Comment is above.
So you should change this line of aliases to this |
|
Woops and thanks for catching it! Fixed and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be a nice addition, as it's soon becoming operational!
added tests in test_GOES.py
otherwise, I've tried generating RGB TrueColor and NaturalColor images, downloading the ABI-L1b-Rad, and it seemed all good (but didn't go further, as I'm not familiar with code base's capabilities!) 🙏