Skip to content

Speed up dot with asymmetric #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 4 commits into from
Jul 29, 2025
Merged

Speed up dot with asymmetric #49

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3f61d4
Speed up dot with asymmetric
blegat Jul 29, 2025
b5863e6
Fix
blegat Jul 29, 2025
e081255
Update src/factorization.jl
blegat Jul 29, 2025
4348272
Update src/factorization.jl
blegat Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/factorization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,13 @@ function LinearAlgebra.dot(a::Factorization, b::Factorization)
end

function LinearAlgebra.dot(a::Factorization, b::AsymmetricFactorization)
# `⟨XΛX', UΣV'⟩ = ⟨ΛX'V, X'UΣ⟩`
XtV = a.factor' * right_factor(b)
XtU = a.factor' * left_factor(b)
XtV = MA.broadcast!!(*, XtV, XtU)
XtV = _lmul_diag!!(a.scaling, XtV)
XtV = _rmul_diag!!(XtV, b.scaling)
return sum(XtV)
# `⟨XΛX', UΣV'⟩ = ⟨U'XΛ, ΣV'X⟩`
UtX = left_factor(b)' * a.factor
VtX = right_factor(b)' * a.factor
UtX = MA.broadcast!!(*, UtX, VtX)
UtX = _rmul_diag!!(XtV, a.scaling)
Comment thread
blegat marked this conversation as resolved.
Outdated
UtX = _lmul_diag!!(b.scaling, XtV)
Comment thread
blegat marked this conversation as resolved.
Outdated
return sum(UtX)
end

function _dot_mat_fact(
Expand Down