MB-66396: Interface for IndexInsightsReader
#71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
added a commit
to blevesearch/scorch_segment_api
that referenced
this pull request
Aug 18, 2025
This was referenced Aug 18, 2025
abhinavdangeti
changed the title
abhinavdangeti
changed the title
InsightsIndex
abhinavdangeti
force-pushed
the
mb66396
branch
from
42826d8 to
8c8bc23
Compare
abhinavdangeti
added a commit
to blevesearch/scorch_segment_api
that referenced
this pull request
Aug 18, 2025
abhinavdangeti
force-pushed
the
mb66396
branch
from
8c8bc23 to
1d0b371
Compare
abhinavdangeti
changed the title
InsightsIndexIndexInsightsReader
abhinavdangeti
added a commit
to blevesearch/scorch_segment_api
that referenced
this pull request
Aug 18, 2025
abhinavdangeti
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
capemox and
maneuvertomars
capemox
approved these changes
Sep 11, 2025
Comment on lines
+370
to
+374
|
|
||
| type TermFreq struct { | ||
| Term string `json:"term"` | ||
| Frequency uint64 `json:"frequency"` | ||
| } |
There was a problem hiding this comment.
not required, the struct required is already defined, this becomes duplicate Count === Frequency
type DictEntry struct {
Term string
Count uint64
EditDistance uint8
}
There was a problem hiding this comment.
Fair, just created a separate entry for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.