Skip to content

Conversation

@CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Aug 21, 2025

This PR introduces support for nested fields within the Zapx indexing API. Key changes include:

  • Nested Field Handling: Implemented functionality to handle fields that contain other fields, facilitating the indexing of hierarchical data structures.

  • Indexing Enhancements: Updated the indexing process to accommodate nested fields, ensuring that they are properly indexed and searchable.

  • Query Adjustments: Modified query mechanisms to support searching within nested fields, providing more granular search capabilities.

This enhancement improves the flexibility of the data model and enhances the overall search experience by allowing more complex data structures to be represented and queried effectively.

Requires:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for nested fields within the Zapx indexing API, enabling indexing and querying of hierarchical data structures. The implementation includes functionality to handle nested document relationships through parent-child edges and provides efficient caching mechanisms.

Key changes include:

  • Added nested document indexing with parent-child relationship tracking through edge lists
  • Implemented nested index cache system for efficient ancestry and descendant lookups
  • Modified document counting to distinguish between root documents and nested sub-documents

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
segment.go Core segment functionality with nested index cache integration and document relationship methods
nested_cache.go New caching system for nested document relationships with ancestry/descendant tracking
new.go Document flattening logic and edge list serialization for nested structures
merge.go Merge operations extended to handle nested document edge lists and sub-document drops
read.go Added method to calculate edge list offset in segment data
dict.go Dictionary operations updated to include sub-documents in exclusion handling
faiss_vector_posting.go Vector index operations updated to handle sub-document exclusions
build.go Segment base initialization updated to include nested index cache
section_inverted_text_index.go Reset functionality updated to clear field addresses map
section_synonym_index.go Reset functionality updated to clear thesaurus addresses map

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

CascadingRadium and others added 2 commits September 13, 2025 22:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

CascadingRadium and others added 5 commits September 13, 2025 22:16
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

merge.go:1

  • The word 'descendent' should be spelled 'descendant' to match the correct spelling used elsewhere in the codebase.
//  Copyright (c) 2017 Couchbase, Inc.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants