Skip to content

Conversation

@CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Nov 6, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GPU acceleration support for FAISS vector index training in the zap package. The implementation provides a best-effort approach to use GPUs when available and configured, with graceful fallback to CPU training when GPU resources are unavailable or insufficient.

Key Changes:

  • Added GPU training capability with automatic fallback to CPU training
  • Introduced vector index options to persist GPU configuration preferences
  • Implemented intelligent GPU device selection based on available memory

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File Description
faiss_vector_gpu.go New file implementing GPU training logic, device selection algorithm, and resource management for FAISS index training
faiss_vector_gpu_test.go New test file with basic tests for GPU enumeration and device selection
section_faiss_vector_index.go Updated to support vector index options, integrate GPU training into merge and write operations, and persist GPU configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CascadingRadium CascadingRadium changed the title GPU-Accelerated Vector Search [v17] MB-68591: GPU-Accelerated Vector Search Nov 13, 2025
@CascadingRadium CascadingRadium changed the base branch from master to fieldOptions November 13, 2025 13:09
Base automatically changed from fieldOptions to unstable-v17 November 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants