-
Notifications
You must be signed in to change notification settings - Fork 14
[v17] MB-68591: GPU-Accelerated Vector Search #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable-v17
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds GPU acceleration support for FAISS vector index training in the zap package. The implementation provides a best-effort approach to use GPUs when available and configured, with graceful fallback to CPU training when GPU resources are unavailable or insufficient.
Key Changes:
- Added GPU training capability with automatic fallback to CPU training
- Introduced vector index options to persist GPU configuration preferences
- Implemented intelligent GPU device selection based on available memory
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| faiss_vector_gpu.go | New file implementing GPU training logic, device selection algorithm, and resource management for FAISS index training |
| faiss_vector_gpu_test.go | New test file with basic tests for GPU enumeration and device selection |
| section_faiss_vector_index.go | Updated to support vector index options, integrate GPU training into merge and write operations, and persist GPU configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.