feat: add a wallet restore endpoint with mnemonic #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
requested changes
Nov 26, 2023
internal/api/api.go
Outdated
| } | ||
|
|
||
| // Restore the wallet using the mnemonic | ||
| wallet, err := bursa.RestoreWallet(request.Mnemonic) |
There was a problem hiding this comment.
Use bursa.NewDefaultWallet, like above. The results are exactly the same and you don't need the RestoreWallet function, at all.
| wallet, err := bursa.RestoreWallet(request.Mnemonic) | ||
| if err != nil { | ||
| c.JSON(http.StatusInternalServerError, gin.H{"error": "Internal server error"}) | ||
| return |
There was a problem hiding this comment.
Increment our failure metric before returning
| } | ||
|
|
||
| // Return the wallet details | ||
| c.JSON(http.StatusOK, wallet) |
There was a problem hiding this comment.
Define a success metric and increment it here before returning.
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat-create-restore-endpoint
branch
from
cfd1da9
to
307bee3
Compare
wolf31o2
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34