Add toValidSemver utility function #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75661d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddhsuresh
reviewed
Apr 7, 2023
siddhsuresh
requested changes
Apr 7, 2023
vitaliemiron
force-pushed
the
fix-semver-version
branch
from
23593b7
to
81ba77a
Compare
flybayer
approved these changes
Apr 7, 2023
|
Added @vitaliemiron contributions for doc and code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the toValidSemver utility function, ensuring that a given version string complies with the SemVer specification. The function adds a .0 patch version if the input string only consists of a major and minor version (e.g., "1.2" becomes "1.2.0").
I added this function to handle cases where the package version is provided in a shortened format, which might cause issues with SemVer-compliant tools or libraries, such as semver.satisfies. Using toValidSemver ensures that version strings are always in a valid format, preventing potential problems and improving compatibility across our codebase.
Closes: #4112
What are the changes and their implications?
Bug Checklist
pnpm changesetin the root directory)Feature Checklist
pnpm changesetin the root directory)mainbranch)