Add NetworkMonitoringService to check Indexers and Relays in background #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangershony
reviewed
Jun 25, 2024
dangershony
reviewed
Jun 25, 2024
dangershony
reviewed
Jun 25, 2024
dangershony
reviewed
Jun 25, 2024
dangershony
reviewed
Jun 27, 2024
| @@ -104,6 +106,7 @@ public async Task CheckServices(bool force = false) | |||
| { | |||
| _logger.LogError($"Failed to check indexer status url = {indexerUrl.Url}, StatusCode = {response.StatusCode}"); | |||
| } | |||
| OnStatusChanged?.Invoke(); | |||
There was a problem hiding this comment.
Interesting this means we don't need to wait for response it will update the page when it arrives
dangershony
reviewed
Jun 27, 2024
|
|
||
| public async Task CheckAndEnsureServices() | ||
| { | ||
| using (var scope = _serviceProvider.CreateScope()) |
There was a problem hiding this comment.
network service is scoped? how is the scoped lifetime manages in a wasm app I wonder?
There was a problem hiding this comment.
Scoped: The service is created once for the duration of the user’s session in the browser. Essentially, a scoped service in Blazor WebAssembly acts as a singleton within the context of a single user's session.
This means that once a scoped service is created, it remains the same for the entirety of the user's interaction with the Blazor WebAssembly app.
There is no real point in using scoped in wasm @DavidGershony
dangershony
reviewed
Jun 27, 2024
| } | ||
| catch (Exception ex) | ||
| { | ||
| Console.Error.WriteLine($"Error checking services: {ex.Message}"); |
There was a problem hiding this comment.
replace with logs no console
dangershony
reviewed
Jun 27, 2024
src/Angor/Shared/Angor.Shared.csproj
Outdated
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Blockcore.Core" Version="1.1.41" /> | |||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.0" /> | |||
There was a problem hiding this comment.
why do we need Hosting.Abstractions? what component uses it?
does it mean we pull more data on load?
There was a problem hiding this comment.
This is related to the previous code and should be removed
dangershony
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.