Libraries upgrade 2 (#450) #280
Annotations
2 errors and 10 warnings
The run was canceled by @sondreb.
|
Unit Test
The operation was canceled.
|
Unit Test:
src/Blockcore/NBitcoin/Bloom.cs#L1
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/AsyncWork/AsyncLoop.cs#L1
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerServer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerServer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/NBitcoin/BitcoinStream.cs#L1
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/PeerConnector.cs#L1
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Protocol/Behaviors/NetworkPeerBehavior.cs#L1
Ensure that 'NetworkPeerBehavior.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/home/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Loading