Mobile: add anchored reaction popover - #5025
Conversation
Signed-off-by: kenny lopez <klopez4212@gmail.com>
|
🤖 Emoji-only actionA reaction-only system event opens the anchored frosted popover.
Full action sheet fallbackA regular message keeps the existing sheet when more actions are available.
|
Signed-off-by: kenny lopez <klopez4212@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fca0644798
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MessageLongPressRegion had no callers outside this file, so making it private satisfies the one-public-widget-per-file convention without changing any behavior. Co-authored-by: kenny lopez <klopez4212@gmail.com> Signed-off-by: kenny lopez <klopez4212@gmail.com>
|
Commenting on Wes's behalf after the Royal Court review. The gesture recognizer, cancellation behavior, fallback gating, animation lifecycle, and existing regression coverage all look solid. We found one medium layout edge worth fixing before merge: P2 — Keep the reaction tray vertically on-screen when neither side of the anchor fully fits. In Please compute the available safe space on both sides and clamp the final Reviewed at exact head |
Signed-off-by: kenny lopez <klopez4212@gmail.com>
|
🤖 @wesbillman Addressed in
Checks: |
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Re-reviewed on Wes's behalf at f1231c51e59b91e0175136f1380b146492292a2a.
The follow-up resolves my prior layout finding. It now measures usable space above and below the anchor, chooses the viable/roomier side, and clamps the final tray position within the safe-area and keyboard bounds. The new 320×240 widget test constructs the neither-side-fits case and asserts the rendered tray stays between the top safe inset and visible bottom.
Focused verification on this exact head:
flutter test test/features/channels/message_actions_test.dart— 17/17 passedflutter analyze lib/features/channels/message_actions/reaction_popover.dart test/features/channels/message_actions_test.dart— no issuesdart format --output=none --set-exit-if-changed ...— cleangit diff --check 69824baf..f1231c51e— clean
No remaining findings from me. I recommend approval and merge.
|
Temporarily closing and immediately reopening to re-trigger the pull_request CI workflow; the prior run never materialized after the GitHub Actions outage. No code or review disposition changed. |
Pull request was closed
…-log-harness * origin/main: feat(desktop): adding rich link previews to messages (#3818) fix(buzz-agent): Responses reasoning summary, Anthropic display:summarized, ACP v2 messageId (#5195) fix(desktop): retain distinct agent instances in autocomplete (#5202) fix(desktop): defer channel visibility change to Save (#5203) feat(desktop): Projects follow-ups — access restrictions, fast loading, activity feed polish (#5073) refactor(cli): replace probe/decider/detail split with single typed extractor (#5191) fix(desktop): drop unhandled rejection from throwing window.Notification (#5143) fix(desktop): fence localStorage SecurityError from killing the React tree (#5142) fix(desktop): make terminal output selectable (#4980) fix(desktop): use WEBKIT_DMABUF_RENDERER_FORCE_SHM for NVIDIA/AppImage (#3654) (#4505) Make public starter channels best effort (#5192) Mobile: add anchored reaction popover (#5025) feat(mobile): add bee pull-to-refresh (#5059) Signed-off-by: Atish Patel <atish@squareup.com>
* origin/main: (32 commits) Recover from max-token response truncation (#5223) chore(release): release Buzz Desktop version 0.5.6 (#5214) fix(mobile): keep latest messages above composer (#4981) fix(sdk): preserve self-mention p tags in message and forum event builders (#4975) bump @tauri-apps/cli to ~2.11.4 to fix linux app icon issue (#4858) feat(desktop): adding rich link previews to messages (#3818) fix(buzz-agent): Responses reasoning summary, Anthropic display:summarized, ACP v2 messageId (#5195) fix(desktop): retain distinct agent instances in autocomplete (#5202) fix(desktop): defer channel visibility change to Save (#5203) feat(desktop): Projects follow-ups — access restrictions, fast loading, activity feed polish (#5073) refactor(cli): replace probe/decider/detail split with single typed extractor (#5191) fix(desktop): drop unhandled rejection from throwing window.Notification (#5143) fix(desktop): fence localStorage SecurityError from killing the React tree (#5142) fix(desktop): make terminal output selectable (#4980) fix(desktop): use WEBKIT_DMABUF_RENDERER_FORCE_SHM for NVIDIA/AppImage (#3654) (#4505) Make public starter channels best effort (#5192) Mobile: add anchored reaction popover (#5025) feat(mobile): add bee pull-to-refresh (#5059) Remove agent creation success modal (#5063) fix(buzz-agent): escalate LLM timeouts per retry and log per-call latency (#5130) ... Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # desktop/src/shared/api/tauri.ts
2 participants
Summary
Testing
flutter analyzeflutter test(1,248 tests)