Skip to content

Remove agent creation success modal - #5063

Merged
klopez4212 merged 1 commit into
mainfrom
kennylopez-remove-agent-created-modal
Aug 7, 2026
Merged

Remove agent creation success modal#5063
klopez4212 merged 1 commit into
mainfrom
kennylopez-remove-agent-created-modal

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • remove the post-creation private-key modal
  • return directly to the underlying page with one “Agent created” toast
  • preserve failed channel-attachment retry through an actionable toast

Validation

  • desktop checks and E2E build
  • 4,392 desktop unit tests
  • focused Playwright coverage for standard, customized, and attachment-retry creation flows

Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212
klopez4212 marked this pull request as ready for review August 6, 2026 15:42
@klopez4212
klopez4212 requested a review from a team as a code owner August 6, 2026 15:42

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 579710a947

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/agents/useCreatedAgentChannelAttachment.ts
Comment thread desktop/src/features/agents/useCreatedAgentChannelAttachment.ts

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Carl on Wes’s behalf at exact head 579710a94752dc14d5738a01c9bad6f854c7c9d9. The modal removal is reasonable, but the contextual create flow now silently discards start/profile-sync failures while showing a success-only toast. That is a user-visible correctness blocker; modal-free does not require error-free. Please surface the partial failure in the toast and cover it in the contextual E2E flow.

Comment thread desktop/src/features/agents/useCreatedAgentChannelAttachment.ts
@klopez4212
klopez4212 merged commit c8743b2 into main Aug 7, 2026
47 of 48 checks passed
@klopez4212
klopez4212 deleted the kennylopez-remove-agent-created-modal branch August 7, 2026 16:03
wpfleger96 pushed a commit that referenced this pull request Aug 7, 2026
* origin/main: (32 commits)
  Recover from max-token response truncation (#5223)
  chore(release): release Buzz Desktop version 0.5.6 (#5214)
  fix(mobile): keep latest messages above composer (#4981)
  fix(sdk): preserve self-mention p tags in message and forum event builders (#4975)
  bump @tauri-apps/cli to ~2.11.4 to fix linux app icon issue (#4858)
  feat(desktop): adding rich link previews to messages (#3818)
  fix(buzz-agent): Responses reasoning summary, Anthropic display:summarized, ACP v2 messageId (#5195)
  fix(desktop): retain distinct agent instances in autocomplete (#5202)
  fix(desktop): defer channel visibility change to Save (#5203)
  feat(desktop): Projects follow-ups — access restrictions, fast loading, activity feed polish (#5073)
  refactor(cli): replace probe/decider/detail split with single typed extractor (#5191)
  fix(desktop): drop unhandled rejection from throwing window.Notification (#5143)
  fix(desktop): fence localStorage SecurityError from killing the React tree (#5142)
  fix(desktop): make terminal output selectable (#4980)
  fix(desktop): use WEBKIT_DMABUF_RENDERER_FORCE_SHM for NVIDIA/AppImage (#3654) (#4505)
  Make public starter channels best effort (#5192)
  Mobile: add anchored reaction popover (#5025)
  feat(mobile): add bee pull-to-refresh (#5059)
  Remove agent creation success modal (#5063)
  fix(buzz-agent): escalate LLM timeouts per retry and log per-call latency (#5130)
  ...

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

# Conflicts:
#	desktop/src/shared/api/tauri.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants