fix: show workflows from all member channels in Desktop overview - #5339
Open
joaoh82 wants to merge 1 commit into
Open
fix: show workflows from all member channels in Desktop overview#5339joaoh82 wants to merge 1 commit into
joaoh82 wants to merge 1 commit into
Conversation
The Workflows tab batched every member channel into one multi-value #h filter. The relay's extract_channel_id_from_filter collapsed multi-#h to the first iterated UUID and SQL-scoped to that single channel, so cards outside that channel (e.g. Engineering's Marvin Ticket Dispatcher) never appeared. - Relay: only push channel_id for single-#h filters; multi-#h stays open for accessible-channel scope + NIP-01 OR post-filter. - Desktop: issue N single-#h filters (one round-trip, NIP-01 OR) so the overview works even against unfixed relays. Co-authored-by: Joao Henrique Machado Silva <joaoh82@gmail.com> Signed-off-by: Joao Henrique Machado Silva <joaoh82@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Desktop Workflows tab only showed workflows from one channel (often the DM-scoped card) and omitted others such as Engineering's
Marvin Ticket Dispatcher, even though single-channel queries returned them.Root cause: Desktop batched all member-channel UUIDs into one multi-value
#hfilter. On the HTTP/querypath,extract_channel_id_from_filtercollapsed multi-#hto the first iterated UUID and SQL-scoped to that single channel, dropping every other channel's kind:30620 events.Changes
extract_channel_id_from_filter): only push SQLchannel_idfor exactly one#hvalue. Multi-value#his NIP-01 OR and leaves channel scope open for accessible-channel filtering + post-match (aligned with the WS REQ path).get_channels_workflows): issue N single-#hfilters in one round-trip instead of one multi-#hfilter, so the overview works even against unfixed production relays.Test plan
cargo test -p buzz-relay extract_channel_id_from_filter --lib(3 new + existing extract tests)cargo clippy -p buzz-relay --lib --tests -- -D warningschannels_workflows_filters(added; fullbuzz-desktoplib build needs local cmake/opus toolchain)buzz workflows list --channel <eng>unchangedNotes
Separate from #5048 (ACP workflow agent wake). This only restores discovery in the Workflows overview.