Skip to content

test(uniswap): validate proposal 100 v4 fees#100

Open
blockfulintern wants to merge 1 commit into
mainfrom
uni/proposal-100-v4-fees
Open

test(uniswap): validate proposal 100 v4 fees#100
blockfulintern wants to merge 1 commit into
mainfrom
uni/proposal-100-v4-fees

Conversation

@blockfulintern

Copy link
Copy Markdown
Contributor

Summary

  • independently reconstructs all 7 executable calls in UNI proposal 100 from named contracts and Solidity interfaces
  • verifies Ethereum plus Arbitrum, Base, BNB Chain, Polygon, Optimism, and Robinhood Chain bridge messages
  • compares the manual derivation byte-for-byte with the live proposal calldata

Security review

Verdict: APPROVE

All targets, values, selectors, and nested cross-chain payloads match the live proposal. The simulation executes successfully and confirms:

  • Ethereum PoolManager changes its protocol fee controller from zero to the deployed V4FeeAdapter
  • both Arbitrum-style retryable tickets spend the exact expected ETH
  • each remote-chain bridge or messenger emits exactly one delivery event
  • Governor and Timelock retain no retryable-ticket ETH

No critical or important findings.

Test plan

git clone https://github.com/blockful/dao-proposals.git
cd dao-proposals
git checkout 98d19e6
npm install --ignore-scripts
MAINNET_RPC_URL=https://eth-mainnet.public.blastapi.io forge test \
  --match-path 'src/uniswap/proposals/100 - Activate v4 Protocol Fees Part 1/*' -vv

Result: 1 passed; 0 failed; 0 skipped.

ClickUp: https://app.clickup.com/t/86ajm0bkq
Proposal: https://anticapture.com/UNI/governance/proposal/100
Transaction: https://etherscan.io/tx/0xa8ea4b2d438c82462ada1e24ed265d617963c667d4dcca3a67f94e1073cc5a3d

@pikonha
pikonha requested a review from alextnetto July 20, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant