feat(domain): lower ACTIVE_VOTE_THRESHOLD from 7 to 6#105
Open
LeonardoVieira1630 wants to merge 3 commits into
Open
feat(domain): lower ACTIVE_VOTE_THRESHOLD from 7 to 6#105LeonardoVieira1630 wants to merge 3 commits into
LeonardoVieira1630 wants to merge 3 commits into
Conversation
A voter now qualifies as active by voting on 6 of the last 10 finalized proposals. Boundary tests and docs updated accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Client-side avatar resolution (wagmi's useEnsAvatar) breaks on NFT avatar records hosted by the OpenSea Shared Storefront: their tokenURI points at OpenSea's deprecated v1 API, which sends no CORS headers, so the browser blocks the fetch and the avatar silently falls back to a blockie (e.g. simona.eth). Resolve avatars through https://metadata.ens.domains instead, which dereferences NFT records server-side. Adds ensAvatar.ts with a URL builder and a useVerifiedEnsAvatar hook that probes the image before using it. EnsAvatar keeps the blockie as an onError/placeholder fallback for names with no avatar record. Also drops the per-avatar RPC call that useEnsAvatar issued in long lists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fix(avatar): resolve ENS avatars via the metadata service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/domain/src/config.ts(ACTIVE_VOTE_THRESHOLD), consumed by the backend eligibility computation — no frontend change needed (the UI derives participation from API data).algorithm.md,prd.md) kept in sync.Impact
Test plan
pnpm --filter @ens-dis/domain test— 211 passedtsc --noEmitclean🤖 Generated with Claude Code