Add accelerated vesting (#1) #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update dependencies * revert some debugging stuff * WIP integration tests erroring with BlockhashNotFound * WIP fix test suite * WIP setting up accelerate investing tests * WIP test correctly fails for bad grant authority * basic accelerated vesting and tests * improve comment * delete debugging log * remove added logs * remove old import * fmt * update rust toolchain to 1.65 * rever then_some * rename accelerate vesting => unlock deposit * add suggested checks * refactor to use LockupData struct; run cargo fmt * fix log test by not using preflight
ckamm
reviewed
Dec 21, 2023
There was a problem hiding this comment.
When I run the tests, I get a failure:
---- test_log_voter_info stdout ----
Created context
thread 'test_log_voter_info' panicked at 'assertion failed: `(left == right)`
left: `4`,
right: `2`', programs/voter-stake-registry/tests/test_log_voter_info.rs:113:5
Will need to check that out
| @@ -36,16 +36,16 @@ bytemuck = "1.9.1" | |||
| # Recently the discriminator for new VoterWeightRecord accounts has changed, and upgrading | |||
| # this dependency here without also upgrading the spl-governance program instance beforehand | |||
| # would lead to VWR accounts that are unusable until the spl-governance program is upgraded. | |||
| spl-governance = { version = "=2.2.1", features = ["no-entrypoint"] } | |||
| spl-governance-addin-api = "=0.1.1" | |||
| spl-governance = { version = "=3.1.1", features = ["no-entrypoint"] } | |||
There was a problem hiding this comment.
this needs to be checked out in relation to the warning above - likely all gov deployments have updated, but need to double check
|
Have fixed the test failure in local merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnlockDeposit allows the grant_authority or realm_authority to completely unlock a single deposit. All tokens in the DepositEntry will be available for immediate withdrawal.
This is identical to mithraiclabs#1